[Release 08-12-2023] OIDC4VC enhancements and major bug fixes #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MOSIP-29934 Signed-off-by: Anup Nehe <[email protected]> * MOSIP-29934 Signed-off-by: Anup Nehe <[email protected]> --------- Signed-off-by: Anup Nehe <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: anil_majji <[email protected]>
Signed-off-by: anil_majji <[email protected]>
* feat(MOSIP-29236): Add reusable workflows * feat(MOSIP-29236): refactor reusable workflows
* refactor(INJI-435): add enum for flow type,end event status & interact event subtype Signed-off-by: PuBHARGAVI <[email protected]> * fix(INJI-435): change flow type value to camel case in getEventType function Signed-off-by: PuBHARGAVI <[email protected]> * feat(INJI-435): add start,interact & impression events in vc activation and create an object with telemetry constants Signed-off-by: PuBHARGAVI <[email protected]> * feat(INJI-435): add end,error events in vc activation flow Signed-off-by: PuBHARGAVI <[email protected]> * feat(INJI-435): increase the pressable area of kebab icon Signed-off-by: PuBHARGAVI <[email protected]> * feat: generate impression event only after going into otp modal & track binding_auth_failed error Signed-off-by: PuBHARGAVI <[email protected]> * refactor(INJI-435): move sendImpression event from addVc modal to otp modal Signed-off-by: PuBHARGAVI <[email protected]> * fix(INJI-435): add missing impression event in issuer machine Signed-off-by: PuBHARGAVI <[email protected]> * refactor(INJI-435): return bindingAuthFailedError from state machines instead of splitting the error in tsx files Signed-off-by: PuBHARGAVI <[email protected]> * fix(INJI-435): add padding and fix the activation status overflow in all languages Signed-off-by: PuBHARGAVI <[email protected]> * refactor(INJI-435): change the telemetry sdk path in package.json Signed-off-by: PuBHARGAVI <[email protected]> * refactor(INJI-435): extract esignetMosipVcItem and existingMosipVcItem machines common functions into separate file Signed-off-by: PuBHARGAVI <[email protected]> * refactor(INJI-435): remove duplicate assignments of selectors Signed-off-by: PuBHARGAVI <[email protected]> --------- Signed-off-by: PuBHARGAVI <[email protected]> Signed-off-by: Swati Goel <[email protected]> Co-authored-by: Swati Goel <[email protected]>
Signed-off-by: anil_majji <[email protected]>
Signed-off-by: anil_majji <[email protected]>
Signed-off-by: kamalsingh <[email protected]>
Signed-off-by: Swati Goel <[email protected]>
chore(MOSIP-29695) - Allow committing .apk file for automation
…for sender (mosip#974) Signed-off-by: Alka <[email protected]>
Signed-off-by: anil_majji <[email protected]>
* fix(INJI-427):refactor selectVC screen while sharing Signed-off-by: Sri Kanth Kola <[email protected]> * fix(INJI-427):refactor selectVC checkbox icon and button height Signed-off-by: Sri Kanth Kola <[email protected]> * fix(INJI-427):remove bottom Tab from share flow Signed-off-by: Sri Kanth Kola <[email protected]> * fix(INJI-427):remove bottom Tab from share flow Signed-off-by: Sri Kanth Kola <[email protected]> * fix(INJI-427):remove bottom Tab from share flow Signed-off-by: Sri Kanth Kola <[email protected]> * fix(INJI-427):refactor bottomTabBar styles into theme files Signed-off-by: Sri Kanth Kola <[email protected]> --------- Signed-off-by: Sri Kanth Kola <[email protected]>
…on to v2 from v1 (mosip#975) * refactor(inji-438): upgrade the authenticate & consent endpoint version to v2 from v1 Signed-off-by: Vijay <[email protected]> * refactor(inji-438): extracted the getJWT method and reused across app Signed-off-by: Vijay <[email protected]> --------- Signed-off-by: Vijay <[email protected]>
…key name Signed-off-by: anil_majji <[email protected]>
… MOSIP-29937 (mosip#971) * MOSIP-29934 Signed-off-by: Anup Nehe <[email protected]> * MOSIP-29934 Signed-off-by: Anup Nehe <[email protected]> * MOSIP-29937 Signed-off-by: Anup Nehe <[email protected]> * MOSIP-29937 Signed-off-by: Anup Nehe <[email protected]> * MOSIP-29937 Signed-off-by: Anup Nehe <[email protected]> * MOSIP-29937 Signed-off-by: Anup Nehe <[email protected]> * MOSIP-29937 Signed-off-by: Anup Nehe <[email protected]> * resolve Signed-off-by: Anup Nehe <[email protected]> --------- Signed-off-by: Anup Nehe <[email protected]>
Dependencies removed 1. expo-status-bar 2. @expo-google-fonts/poppins 3. react-native-simple-markdown 4. react-native-swipe-gestures DevDependencies removed 1. @react-native/metro-config (removed as we already have @expo/metro-config dependency used) 2. metro-react-native-babel-preset 3. @types/react-test-renderer 4. react-test-renderer Signed-off-by: Kiruthika Jeyashankar <[email protected]>
…arch-issuer-from-the-list Feat(Inji-502): Enable user to search issuer from the list in Add New card
…ted. (mosip#981) * refactor(inji-467): encrypt the missed data which is stored unencrypted. Signed-off-by: Vijay <[email protected]> * refactor(inji-467): remove additional i18n import statement Signed-off-by: Vijay <[email protected]> --------- Signed-off-by: Vijay <[email protected]>
…ded (mosip#982) * Test script updated for new apk Signed-off-by: kamalsingh <[email protected]> * new test cases added Signed-off-by: kamalsingh <[email protected]> --------- Signed-off-by: kamalsingh <[email protected]>
…osip#984) * feat(inji-533): add null check before decrypting the data Signed-off-by: Tilak Puli <[email protected]> * feat(inji-533): add null check for decrypt json for both hardware keystore and cryptojs Signed-off-by: Tilak Puli <[email protected]> --------- Signed-off-by: Tilak Puli <[email protected]>
… screen (mosip#987) Signed-off-by: adityankannan-tw <[email protected]>
…p#986) * refactor(INJI-435): add enum for flow type,end event status & interact event subtype Signed-off-by: PuBHARGAVI <[email protected]> * fix(INJI-435): change flow type value to camel case in getEventType function Signed-off-by: PuBHARGAVI <[email protected]> * feat(INJI-435): add start,interact & impression events in vc activation and create an object with telemetry constants Signed-off-by: PuBHARGAVI <[email protected]> * feat(INJI-435): add end,error events in vc activation flow Signed-off-by: PuBHARGAVI <[email protected]> * feat(INJI-435): increase the pressable area of kebab icon Signed-off-by: PuBHARGAVI <[email protected]> * feat: generate impression event only after going into otp modal & track binding_auth_failed error Signed-off-by: PuBHARGAVI <[email protected]> * refactor(INJI-435): move sendImpression event from addVc modal to otp modal Signed-off-by: PuBHARGAVI <[email protected]> * fix(INJI-435): add missing impression event in issuer machine Signed-off-by: PuBHARGAVI <[email protected]> * refactor(INJI-435): return bindingAuthFailedError from state machines instead of splitting the error in tsx files Signed-off-by: PuBHARGAVI <[email protected]> * fix(INJI-435): add padding and fix the activation status overflow in all languages Signed-off-by: PuBHARGAVI <[email protected]> * refactor(INJI-435): change the telemetry sdk path in package.json Signed-off-by: PuBHARGAVI <[email protected]> * refactor(INJI-435): extract esignetMosipVcItem and existingMosipVcItem machines common functions into separate file Signed-off-by: PuBHARGAVI <[email protected]> * refactor(INJI-435): remove duplicate assignments of selectors Signed-off-by: PuBHARGAVI <[email protected]> * feat(INJI-436): add telemetry events to track the app generated warnings Signed-off-by: PuBHARGAVI <[email protected]> * fix(INJI-436): remove duplicate telemetry constant import in QR login file Signed-off-by: PuBHARGAVI <[email protected]> * refactor(INJI-436): remove unused app id import in app.tsx Signed-off-by: PuBHARGAVI <[email protected]> --------- Signed-off-by: PuBHARGAVI <[email protected]>
* feat(INJI-299): show cancel download popup for ios Signed-off-by: Pooja Babusingh <[email protected]> * feat(INJI-299): move translations from addVCModal to otpVerificationModal Signed-off-by: Pooja Babusingh <[email protected]> --------- Signed-off-by: Pooja Babusingh <[email protected]> Co-authored-by: Pooja Babusingh <[email protected]>
…cel button handle (mosip#990) * refactor(INJI-434): rename some variables and functions to meaning names Signed-off-by: Alka <[email protected]> * feat(INJI-434): add telemetry events in the VC share flow on verifier end Signed-off-by: Alka <[email protected]> * fix(INJI-434): handle cancel button press during vc share Signed-off-by: Alka <[email protected]> * fix(INJI-441): handle cancel button press during vc share Signed-off-by: Alka <[email protected]> * refactor(INJI-434): extracts telemetry constants to a seperate file Signed-off-by: Alka <[email protected]> * refactor(INJI-434): remove unused imports Signed-off-by: Alka <[email protected]> * fix(INJI-441): update the CANCEL event on press of cancel button Signed-off-by: Alka <[email protected]> * refactor(INJI-434): update the method name Signed-off-by: Alka <[email protected]> --------- Signed-off-by: Alka <[email protected]> Signed-off-by: Alka Prasad <[email protected]>
* Test script updated for new apk Signed-off-by: kamalsingh <[email protected]> * new test cases added Signed-off-by: kamalsingh <[email protected]> * new test cases added from master sheet Signed-off-by: kamalsingh <[email protected]> --------- Signed-off-by: kamalsingh <[email protected]>
* MOSIP-29934 Signed-off-by: Anup Nehe <[email protected]> * MOSIP-29934 Signed-off-by: Anup Nehe <[email protected]> * MOSIP-29937 Signed-off-by: Anup Nehe <[email protected]> * MOSIP-29937 Signed-off-by: Anup Nehe <[email protected]> * MOSIP-29937 Signed-off-by: Anup Nehe <[email protected]> * MOSIP-29937 Signed-off-by: Anup Nehe <[email protected]> * MOSIP-29937 Signed-off-by: Anup Nehe <[email protected]> * resolve Signed-off-by: Anup Nehe <[email protected]> * MOSIP-30054 Signed-off-by: Anup Nehe <[email protected]> * MOSIP-30082 Signed-off-by: Anup Nehe <[email protected]> * added testng.xml Signed-off-by: Anup Nehe <[email protected]> * MOSIP-30125 MOSIP-30054 Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> --------- Signed-off-by: Anup Nehe <[email protected]>
* fix(INJI-558): fix sharing screen progress modal in ios Signed-off-by: adityankannan-tw <[email protected]> Co-authored-by: Vijay <[email protected]> * fix(inji-558): remove isVisible prop from Loader Component. Signed-off-by: Vijay <[email protected]> * refactor(INJI-558): refactor selectors to match the state Signed-off-by: adityankannan-tw <[email protected]> * fix(inji-558): remove optional field for title prop. Signed-off-by: Vijay <[email protected]> --------- Signed-off-by: adityankannan-tw <[email protected]> Signed-off-by: Vijay <[email protected]> Signed-off-by: adityankannan-tw <[email protected]> Co-authored-by: Vijay <[email protected]>
…r scenarios (mosip#1012) Signed-off-by: Alka <[email protected]>
* feat(INJI-474): show popup for invalid QR * at times a scanned QR code is neither online nor offline Co-authored-by: adityankannan-tw <[email protected]> Signed-off-by: Harsh Vardhan <[email protected]> * refactor(INJI-474): add a dismiss-able popup w buttons Signed-off-by: Harsh Vardhan <[email protected]> * feat(INJI-474): use polyfill for URL searchParams feat Signed-off-by: Harsh Vardhan <[email protected]> * feat(INJI-474): move popup buttons to a single row Signed-off-by: Harsh Vardhan <[email protected]> * refactor(INJI-474): align buttons in popup Co-authored-by: Anil kumar M <[email protected]> Signed-off-by: Harsh Vardhan <[email protected]> * feat(INJI-474): don't show Loader on invalidQR & fix QR type logic Signed-off-by: Harsh Vardhan <[email protected]> * refactor(INJI-474): propagate btn style changes to Themes Co-authored-by: Vijay <[email protected]> Signed-off-by: Harsh Vardhan <[email protected]> --------- Signed-off-by: Harsh Vardhan <[email protected]> Co-authored-by: Harsh Vardhan <[email protected]> Co-authored-by: Anil kumar M <[email protected]> Co-authored-by: Vijay <[email protected]>
…e purple theme are fixed. (mosip#1021) * Feat(INJI-261): Some elements still appearing orange colour in the purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Some elements still appearing orange colour in the purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the home screen icons to purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the comments of respective PR Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the comments of respective PR Signed-off-by: anil_majji <[email protected]> --------- Signed-off-by: anil_majji <[email protected]>
* Test script updated for new apk Signed-off-by: kamalsingh <[email protected]> * new test cases added Signed-off-by: kamalsingh <[email protected]> * new test cases added from master sheet Signed-off-by: kamalsingh <[email protected]> * Test cases added from regression sheet Signed-off-by: kamalsingh <[email protected]> * new test cases added Signed-off-by: kamalsingh <[email protected]> * automated ios tests for regression Signed-off-by: kamalsingh <[email protected]> * conflict resolved Signed-off-by: kamalsingh <[email protected]> --------- Signed-off-by: kamalsingh <[email protected]>
…-30054 MOSIP-30230 MOSIP-30282 (mosip#1024) * MOSIP-30054 MOSIP-30230 MOSIP-30282 Signed-off-by: Anup Nehe <[email protected]> * resolve conflicts Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> --------- Signed-off-by: Anup Nehe <[email protected]>
Signed-off-by: Sri Kanth Kola <[email protected]>
…decryption (mosip#1034) * refactor(INJI-449): replace crypo-js with node-forge crypto-js has vulneraribitiles prior to version 4.2.0 for encryption / decryption & 4.x.x version is not compatible with our react native project For this reason we had to move to different library for encryption / decryption Co-authored-by: Sreenadh S <[email protected]> Signed-off-by: Kiruthika Jeyashankar <[email protected]> * fix(INJI-449): secure-keystore warning popup shown on reload of app settings key which was stored in storage was not loaded into settings machine context correctly, which caused the bug - on reload settings related flows was falling back to initial setting. Co-authored-by: Sreenadh S <[email protected]> Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): gitignore automation test results Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): simplify usage of methods in node-forge Signed-off-by: Kiruthika Jeyashankar <[email protected]> --------- Signed-off-by: Kiruthika Jeyashankar <[email protected]> Co-authored-by: Sreenadh S <[email protected]>
…p#1035) * refactor(INJI-449): remove unused dependencies Dependencies removed 1. expo-status-bar 2. @expo-google-fonts/poppins 3. react-native-simple-markdown 4. react-native-swipe-gestures DevDependencies removed 1. @react-native/metro-config (removed as we already have @expo/metro-config dependency used) 2. metro-react-native-babel-preset 3. @types/react-test-renderer 4. react-test-renderer Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): update expo related packages and crypto-js Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): update transitive dependency of expo-updates package plist package is a transitive dependency of expo-updates which had vulnerability - Prototype pollution vulnerability via .parse() in Plist before v3.0.4 allows attackers to cause a Denial of Service (DoS) and may lead to remote code execution. Thus this package was updated to fix vulnerability Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): update axios dependency of telemetry-sdk to 1.6.0 Since the package axios(1.5.0) has vulnerability - Cross-Site Request Forgery (CSRF), it is updated to 1.6.0 Signed-off-by: Kiruthika Jeyashankar <[email protected]> * fix(INJI-449): vulnerablity issue with @digitalbazaar/rsa-verification-key-2018 override the node-forge dependency of the package - @digitalbazaar/rsa-verification-key-2018 as it has the high severity with CVE count 13 Signed-off-by: Kiruthika Jeyashankar <[email protected]> * revert(INJI-449): downgrade crypto-js to 3.3.0 from 4.x.x version Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): use expo-splash-screen instead of expo-app-loading expo-app-loading package is deprecated and it is suggested to replace it with expo-splash-screen Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): optimize time taken to hide splash screen Co-authored-by: Sreenadh S <[email protected]> Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): change appEntry to index js Change appEntry to index.js file since react-native-url-polyfill/auto is imported to avoid URL error. appEntry is required for expo package update Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-559): update podfile.lock Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): optimize import Signed-off-by: Kiruthika Jeyashankar <[email protected]> --------- Signed-off-by: Kiruthika Jeyashankar <[email protected]>
…tion (mosip#1039) * Test script updated for new apk Signed-off-by: kamalsingh <[email protected]> * new test cases added Signed-off-by: kamalsingh <[email protected]> * new test cases added from master sheet Signed-off-by: kamalsingh <[email protected]> * Test cases added from regression sheet Signed-off-by: kamalsingh <[email protected]> * new test cases added Signed-off-by: kamalsingh <[email protected]> * automated ios tests for regression Signed-off-by: kamalsingh <[email protected]> * conflict resolved Signed-off-by: kamalsingh <[email protected]> * framework optimization Signed-off-by: kamalsingh <[email protected]> * folder structure changed Signed-off-by: kamalsingh <[email protected]> * framework restructure for device farm Signed-off-by: kamalsingh <[email protected]> * incorporated review comments Signed-off-by: kamalsingh <[email protected]> --------- Signed-off-by: kamalsingh <[email protected]>
* feat(mosip-30097): add testId for passcode screen and get id flow Signed-off-by: Pooja Babusingh <[email protected]> * feat(mosip-30097): fix typo for retreiveIdHeader Signed-off-by: Pooja Babusingh <[email protected]> * feat(mosip-30097): add testID for setting screen, histroy, otp verifiction screen Signed-off-by: Pooja Babusingh <[email protected]> * feat(mosip-30097): rename testID for wait and cancel button Signed-off-by: Pooja Babusingh <[email protected]> * feat(mosip-30097): add testID prop to editableListItem Signed-off-by: Pooja Babusingh <[email protected]> --------- Signed-off-by: Pooja Babusingh <[email protected]> Co-authored-by: Pooja Babusingh <[email protected]>
* feat(INJI-503): add configurable issuer title & description Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-503): extract search bar component Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-503): modify display data type Signed-off-by: Kiruthika Jeyashankar <[email protected]> --------- Signed-off-by: Kiruthika Jeyashankar <[email protected]>
* feat(INJI-388): update error message of qr login to specific message Signed-off-by: Alka <[email protected]> * fix(INJI-388): add missing error id constants in telemetry Signed-off-by: Alka <[email protected]> --------- Signed-off-by: Alka <[email protected]>
* fix(INJI-550):refactor setup language and passcode screen Signed-off-by: Sri Kanth Kola <[email protected]> * Fix(INJI-369): After changing the languages made fixes in screens Error, Auth & Intro-Sliders Signed-off-by: anil_majji <[email protected]> * Fix(INJI-550): After changing the languages made fixes in screens Error, Auth & Intro-Sliders Signed-off-by: Sri Kanth Kola <[email protected]> --------- Signed-off-by: Sri Kanth Kola <[email protected]> Signed-off-by: anil_majji <[email protected]> Co-authored-by: anil_majji <[email protected]>
…sip#1048) * refactor(INJI-503): remove unused locales Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-394): modify prop in VCItemContent Remove passing iconType & iconName props in VCItemContent which is used to check if pinned or not to isPinned boolean prop Signed-off-by: Kiruthika Jeyashankar <[email protected]> * feat(INJI-349): show pinned vc on top in QRLogin screen Signed-off-by: Kiruthika Jeyashankar <[email protected]> * feat(INJI-349): show pinned vc on top in VCShare screen Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-349): add type annotation to groupBy method Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): create machine based on first selected vc in share screen Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-394): extract method for vcs ordering by pin status Signed-off-by: Kiruthika Jeyashankar <[email protected]> --------- Signed-off-by: Kiruthika Jeyashankar <[email protected]>
Signed-off-by: Anup Nehe <[email protected]>
Signed-off-by: Anup Nehe <[email protected]>
Signed-off-by: Anup Nehe <[email protected]>
https://mosip.atlassian.net/browse/MOSIP-30442 added esignet testcases
Signed-off-by: Alka <[email protected]>
Alka1703
changed the title
Signed-off-by: Kiruthika Jeyashankar <[email protected]>
…C download flow Signed-off-by: Alka <[email protected]>
…opdown Signed-off-by: Alka <[email protected]>
Signed-off-by: PuBHARGAVI <[email protected]>
swatigoel
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done as part of the sprint 14, 15 , 16 :